Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MOUSE_UP action was ignored if any other mouse button was pressed #941

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ToTheHit
Copy link
Contributor

@ToTheHit ToTheHit commented May 9, 2022

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer/coffee because you are awesome

What? | Why?

#940

How?

Store pressed mouse button and ignore other events if they contain different button.
Also I did a little refactor, because 9 if-else is too much :)

Feel good image:

6e88d91e1473a36ea8aaba8cd6a4eaaf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant